Fix: Make date range inclusive for audits ran in sqlmesh plan#4179
Merged
Fix: Make date range inclusive for audits ran in sqlmesh plan#4179
sqlmesh plan#4179Conversation
georgesittas
approved these changes
Apr 18, 2025
tobymao
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3966
Internally,
start&enddates are converted to exclusive range to accommodate the interval logic and are transformed back to inclusive during render / evaluation.The issue is apparent during plan because:
When running
sqlmesh plan --start <date> --end <date>, we apply the missing interval logic and propagate the exclusive range torender_audit_query; We then create theBETWEENfilter manually without converting the range back to inclusive, as is the case in all other render callsWhen running
sqlmesh audit --start <date> --end <date>, the dates are propagated as-is